From 2ffc4583824cfe11a83646ee84c76c8d3b204576 Mon Sep 17 00:00:00 2001
From: Paul Schneider <paul@pschneider.fr>
Date: Sun, 5 Mar 2017 20:29:02 +0100
Subject: [PATCH] cleaning

---
 Yavsc/ApiControllers/PdfEstimateController.cs    |  8 +++++++-
 Yavsc/Controllers/FormationSettingsController.cs |  2 --
 Yavsc/Controllers/ManageController.cs            |  7 +------
 Yavsc/Helpers/WorkflowHelpers.cs                 | 10 ----------
 4 files changed, 8 insertions(+), 19 deletions(-)

diff --git a/Yavsc/ApiControllers/PdfEstimateController.cs b/Yavsc/ApiControllers/PdfEstimateController.cs
index f87c932f..19647868 100644
--- a/Yavsc/ApiControllers/PdfEstimateController.cs
+++ b/Yavsc/ApiControllers/PdfEstimateController.cs
@@ -17,6 +17,7 @@ namespace Yavsc.ApiControllers
     using Yavsc.Services;
     using Yavsc.Models.Messaging;
     using Yavsc.ViewModels;
+    using Microsoft.Extensions.OptionsModel;
 
     [Route("api/pdfestimate"), Authorize]
     public class PdfEstimateController : Controller
@@ -33,12 +34,17 @@ namespace Yavsc.ApiControllers
             IAuthorizationService authorizationService,
             ILoggerFactory loggerFactory,
             IStringLocalizer<Yavsc.Resources.YavscLocalisation> SR,
-            ApplicationDbContext context)
+            ApplicationDbContext context,
+            IOptions<GoogleAuthSettings> googleSettings,
+            IGoogleCloudMessageSender GCMSender
+            )
         {
+            _googleSettings=googleSettings.Value;
             this.authorizationService = authorizationService;
             dbContext = context;
             logger = loggerFactory.CreateLogger<PdfEstimateController>();
             this._localizer = SR;
+            _GCMSender=GCMSender;
         }
 
         [HttpGet("get/{id}", Name = "Get"), Authorize]
diff --git a/Yavsc/Controllers/FormationSettingsController.cs b/Yavsc/Controllers/FormationSettingsController.cs
index 2672cb49..3b4a4974 100644
--- a/Yavsc/Controllers/FormationSettingsController.cs
+++ b/Yavsc/Controllers/FormationSettingsController.cs
@@ -1,7 +1,5 @@
-using System.Linq;
 using System.Threading.Tasks;
 using Microsoft.AspNet.Mvc;
-using Microsoft.AspNet.Mvc.Rendering;
 using Microsoft.Data.Entity;
 using Yavsc.Models;
 using Yavsc.Models.Workflow.Profiles;
diff --git a/Yavsc/Controllers/ManageController.cs b/Yavsc/Controllers/ManageController.cs
index c8b957fd..eedfc70d 100644
--- a/Yavsc/Controllers/ManageController.cs
+++ b/Yavsc/Controllers/ManageController.cs
@@ -115,14 +115,9 @@ namespace Yavsc.Controllers
             };
             model.HaveProfessionalSettings = _dbContext.Performers.Any(x => x.PerformerId == user.Id);
             var usrActs = _dbContext.UserActivities.Include(a=>a.Does).Where(a=> a.UserId == user.Id);
-            
-            await usrActs.Where(u=>u.Does.SettingsClassName!=null).ForEachAsync(
-                a=>{ a.Settings = a.Does.CreateSettings(User.GetUserId()); }
-            );
 
             model.HaveActivityToConfigure = usrActs.Any( a=> a.Settings == null && a.Does.SettingsClassName!=null );
-            model.Activity = _dbContext.UserActivities.Include(a=>a.Does).Where(u=>u.UserId == user.Id)
-            .ToList();
+            model.Activity = _dbContext.UserActivities.Include(a=>a.Does).Where(u=>u.UserId == user.Id).ToList();
             return View(model);
         }
 
diff --git a/Yavsc/Helpers/WorkflowHelpers.cs b/Yavsc/Helpers/WorkflowHelpers.cs
index 5d26be65..e6bea742 100644
--- a/Yavsc/Helpers/WorkflowHelpers.cs
+++ b/Yavsc/Helpers/WorkflowHelpers.cs
@@ -7,18 +7,8 @@ namespace Yavsc.Helpers
     using Microsoft.Data.Entity;
     using Models.Workflow;
     using Yavsc.Models;
-    using YavscLib;
     public static class WorkflowHelpers
     {
-        public static ISpecializationSettings  CreateSettings (this Activity activity, string userId) {
-            if (activity.SettingsClassName==null) return null;
-            var ctor = Startup.ProfileTypes.Single(t=>t.FullName==activity.SettingsClassName).GetConstructor(System.Type.EmptyTypes);
-            if (ctor==null) return null;
-            ISpecializationSettings result = (ISpecializationSettings) ctor.Invoke(null);
-            result.UserId = userId;
-            return result;
-        }
-
         public static List<PerformerProfile> ListPerformers(this ApplicationDbContext context, string actCode)
         {
             return context.Performers